Messages in this thread |  | | | Date | Tue, 13 Apr 2010 14:10:23 -0400 | | From | Christoph Hellwig <> | | Subject | Re: [PATCH 1/4] blkdev: pass gfp_mask and flags to blkdev_issue_flush |
| |
> +enum{ > + __BLKDEV_IFL_WAIT, /* wait for completion */ > + __BLKDEV_IFL_BARRIER, /*issue request with barrier */ > +}; > +#define BLKDEV_IFL_WAIT (1 << __BLKDEV_IFL_WAIT) > +#define BLKDEV_IFL_BARRIER (1 << __BLKDEV_IFL_BARRIER)
This is a very awkward stayle to define flags. There really should be no need for the __-prefixed version. While you're using them for test/set_bit and co there's no reason to use these atomic bitops here.
|  |