lkml.org 
[lkml]   [2010]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 06/12] perf, x86: use weight instead of cmask in for_each_event_constraint()
    Date
    There may exist constraints with a cmask set to zero. In this case
    for_each_event_constraint() will not work properly. Now weight is used
    instead of the cmask for loop exit detection. Weight is always a value
    other than zero since the default contains the HWEIGHT from the
    counter mask and in other cases a value of zero does not fit too.

    This is in preparation of ibs event constraints that wont have a
    cmask.

    Signed-off-by: Robert Richter <robert.richter@amd.com>
    ---
    arch/x86/kernel/cpu/perf_event.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/arch/x86/kernel/cpu/perf_event.c b/arch/x86/kernel/cpu/perf_event.c
    index f66f52a..feda380 100644
    --- a/arch/x86/kernel/cpu/perf_event.c
    +++ b/arch/x86/kernel/cpu/perf_event.c
    @@ -170,7 +170,7 @@ struct cpu_hw_events {
    EVENT_CONSTRAINT(0, 0, 0)

    #define for_each_event_constraint(e, c) \
    - for ((e) = (c); (e)->cmask; (e)++)
    + for ((e) = (c); (e)->weight; (e)++)

    union perf_capabilities {
    struct {
    --
    1.7.0.3



    \
     
     \ /
      Last update: 2010-04-13 22:29    [W:0.024 / U:59.788 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site