lkml.org 
[lkml]   [2010]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] kcore: fix test for end of list
On Mon, 22 Mar 2010 15:05:09 +0300
Dan Carpenter <error27@gmail.com> wrote:

> "m" is never NULL here. We need a different test for the end of list
> condition.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>

yes, thank you.
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>


> ---
> Found with a static checker and compile tested only. Please review
> carefully.
>
> diff --git a/fs/proc/kcore.c b/fs/proc/kcore.c
> index a44a789..b442dac 100644
> --- a/fs/proc/kcore.c
> +++ b/fs/proc/kcore.c
> @@ -490,7 +490,7 @@ read_kcore(struct file *file, char __user *buffer, size_t buflen, loff_t *fpos)
> }
> read_unlock(&kclist_lock);
>
> - if (m == NULL) {
> + if (&m->list == &kclist_head) {
> if (clear_user(buffer, tsz))
> return -EFAULT;
> } else if (is_vmalloc_or_module_addr((void *)start)) {
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>



\
 
 \ /
  Last update: 2010-03-23 01:25    [W:0.081 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site