Messages in this thread Patch in this message | | | Date | Mon, 22 Mar 2010 15:05:09 +0300 | From | Dan Carpenter <> | Subject | [patch] kcore: fix test for end of list |
| |
"m" is never NULL here. We need a different test for the end of list condition.
Signed-off-by: Dan Carpenter <error27@gmail.com> --- Found with a static checker and compile tested only. Please review carefully.
diff --git a/fs/proc/kcore.c b/fs/proc/kcore.c index a44a789..b442dac 100644 --- a/fs/proc/kcore.c +++ b/fs/proc/kcore.c @@ -490,7 +490,7 @@ read_kcore(struct file *file, char __user *buffer, size_t buflen, loff_t *fpos) } read_unlock(&kclist_lock); - if (m == NULL) { + if (&m->list == &kclist_head) { if (clear_user(buffer, tsz)) return -EFAULT; } else if (is_vmalloc_or_module_addr((void *)start)) {
| |