Messages in this thread | | | Date | Tue, 2 Mar 2010 18:29:27 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH -mm 7/7] pci: move pci_set_dma_mask and pci_set_consistent_dma_mask to pci-dma-compat.h |
| |
On Fri, 12 Feb 2010 18:33:32 +0900 FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> wrote:
> We can use pci-dma-compat.h to implement pci_set_dma_mask and > pci_set_consistent_dma_mask as we do with the other PCI DMA API. > > We can remove HAVE_ARCH_PCI_SET_DMA_MASK too.
i386 allnoconfig:
include/asm-generic/pci-dma-compat.h:105: error: redefinition of 'pci_set_dma_mask' include/linux/pci.h:1092: error: previous definition of 'pci_set_dma_mask' was here include/asm-generic/pci-dma-compat.h:110: error: redefinition of 'pci_set_consistent_dma_mask' include/linux/pci.h:1097: error: previous definition of 'pci_set_consistent_dma_mask' was here
In fact the whole of include/asm-generic/pci-dma-compat.h seems a bit fishy when CONFIG_PCI=n. Shouldn't all those functions be EIO-returning stubs?
| |