Messages in this thread |  | | | Date | Mon, 15 Feb 2010 10:57:58 +0900 | | Subject | Re: [PATCH -mm 5/7] powerpc: use generic pci_set_dma_mask and pci_set_consistent_dma_mask | | From | FUJITA Tomonori <> |
| |
On Mon, 15 Feb 2010 10:36:40 +1100 Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> On Fri, 2010-02-12 at 18:33 +0900, FUJITA Tomonori wrote: > > This converts powerpc to use the generic pci_set_dma_mask and > > pci_set_consistent_dma_mask (drivers/pci/pci.c). > > > > The generic pci_set_dma_mask does what powerpc's pci_set_dma_mask > > does. > > > > Unlike powerpc's pci_set_consistent_dma_mask, the gneric > > pci_set_consistent_dma_mask sets only coherent_dma_mask. It doesn't > > work for powerpc? pci_set_consistent_dma_mask API should set only > > coherent_dma_mask? > > I don't know why we do it that way, your patch looks correct to me, if > we have a driver bug assuming it does both masks at once, then we'll > fix it. > > Do you need me to merge that via powerpc.git or are you happy to carry > it with the rest of your PCI DMA changes ?
I guess it's easier if Andrew carries all the patches since some of the patches in this patchset depend on my other patches in -mm.
> > Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> > > Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Thanks!
|  |