| Date | Wed, 3 Feb 2010 09:36:11 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH 4/14] avr32: use generic ptrace_resume code |
| |
On Wed, Feb 03, 2010 at 08:47:37AM +0530, Haavard Skinnemoen wrote: > Sounds like you found three bugs and fixed two of them. Can you tell me > more about the last one, i.e. what should be done to disable > single-stepping?
I don't think the flag clearing on PTRACE_KILL matters as the process is a zombie and almost gone anyway, it's more an artefact of the generic implementation that I wanted to mention.
It seems like avr32 implement single stepping by setting the TIF_SINGLE_STEP and TIF_BREAKPOINT thread flags. Simply clearing these flags in user_disable_single_step and calling that function from ptrace_disable (which currently clears them itself) should take care of it.
|