Messages in this thread |  | | | Date | Wed, 3 Feb 2010 08:47:37 +0530 | | From | Haavard Skinnemoen <> | | Subject | Re: [PATCH 4/14] avr32: use generic ptrace_resume code |
| |
On Tue, 2 Feb 2010 19:58:57 +0100 Christoph Hellwig <hch@lst.de> wrote:
> Use the generic ptrace_resume code for PTRACE_SYSCALL, PTRACE_CONT, > PTRACE_KILL and PTRACE_SINGLESTEP. This implies defining > arch_has_single_step in <asm/ptrace.h> and implementing the > user_enable_single_step and user_disable_single_step functions, which > also causes the breakpoint information to be cleared on fork, which > could be considered a bug fix. > > Also the TIF_SYSCALL_TRACE thread flag is now cleared on PTRACE_KILL > which it previously wasn't which is consistent with all architectures > using the modern ptrace code. > > Currently avr32 doesn't implement any code to disable single stepping > when one of the non-syscall requests is called which seems wrong, > but I've left it as-is for now. > > Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
Sounds like you found three bugs and fixed two of them. Can you tell me more about the last one, i.e. what should be done to disable single-stepping?
Haavard
|  |