Messages in this thread | | | Subject | Re: [PATCH 03/06] kernel.h hexdump cleanup | From | Joe Perches <> | Date | Mon, 22 Feb 2010 11:43:31 -0800 |
| |
On Mon, 2010-02-22 at 22:19 +0800, Dave Young wrote: > hexdump stuff in kernel.h should be put into a standalone head file
I think it'd be clearer to have logging functions in kernel.h split into a separate header or grouped a bit better in kernel.h.
I would have kernel.h #include that header though rather than splitting out things like hexdump functions into a separate file requiring yet another #include in source files.
http://lkml.org/lkml/2009/12/16/77 http://lkml.org/lkml/2007/11/29/507
| |