Messages in this thread | | | Date | Thu, 25 Feb 2010 11:27:29 +0800 | Subject | Re: [PATCH 03/06] kernel.h hexdump cleanup | From | Dave Young <> |
| |
On Thu, Feb 25, 2010 at 10:16 AM, Andrew Morton <akpm@linux-foundation.org> wrote: > On Thu, 25 Feb 2010 09:52:49 +0800 Dave Young <hidave.darkstar@gmail.com> wrote: > >> On Tue, Feb 23, 2010 at 3:43 AM, Joe Perches <joe@perches.com> wrote: >> > On Mon, 2010-02-22 at 22:19 +0800, Dave Young wrote: >> >> hexdump stuff in kernel.h should be put into a standalone head file >> > >> > I think it'd be clearer to have logging functions >> > in kernel.h split into a separate header or grouped >> > a bit better in kernel.h. >> > >> > I would have kernel.h #include that header though >> > rather than splitting out things like hexdump functions >> > into a separate file requiring yet another #include in >> > source files. >> >> Andrew, what do you think about this? > > Well. Avoiding bisection-bustage is hardly a priority any more, but > let's not break bisection this time if we can avoid it.
Thanks, see it.
> >> Actually I hesitate to send this patch as well, too many recipients >> needed from get_maintainer.pl. > > They'll live ;) >
-- Regards dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |