lkml.org 
[lkml]   [2010]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: Commit 085219f79cad broke Sparc-32 back in 2.6.28.
Date
On Monday 22 February 2010 12:57:19 am David Miller wrote:
> From: Rob Landley <rob@landley.net>
> Date: Sun, 21 Feb 2010 10:25:09 -0600
>
> > 085219f79cad89291699bd2bfb21c9fdabafe65f is first bad commit
> > commit 085219f79cad89291699bd2bfb21c9fdabafe65f
> > Author: Sam Ravnborg <sam@ravnborg.org>
> > Date: Fri Jan 2 18:47:34 2009 -0800
> >
> > sparc32: use proper types in struct stat
> >
> > Like sparc64 use proper types in struct stat
> >
> > Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> > Signed-off-by: David S. Miller <davem@davemloft.net>
> >
> > This commit breaks stat and makes sparc32 essentially unusable. It changes
> > the size of the various types in stat.h, and means that if you "mount -t tmpfs
> > /tmp /tmp" and then try to ls /tmp, ls dies with a memory allocation error.
> >
> > I've confirmed that reverting it fixes the problem.
>
> Thanks for tracking this down Rob, I'll work on a fix and
> push it around.

Looking at how whole sparc32 has been apparently broken for over a year now
because of a purely cleanup patch I wonder if it would be appropriate to
make sparc32 into 'legacy only' and provide 'a stability promise' for it?

Just an idea.. ;)

--
Bartlomiej Zolnierkiewicz


\
 
 \ /
  Last update: 2010-02-22 01:33    [W:0.509 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site