Messages in this thread Patch in this message | | | From | Rob Landley <> | Subject | Re: Commit 085219f79cad broke Sparc-32 back in 2.6.28. | Date | Sat, 27 Mar 2010 02:44:16 -0500 |
| |
On Friday 26 March 2010 22:37:45 David Miller wrote: > From: Rob Landley <rob@landley.net> > Date: Fri, 26 Mar 2010 22:35:47 -0500 > > > What exactly was the problem with just saying "unsigned short" when you > > mean an unsigned short? The way x86 does, and arm? (If these ever > > change, it breaks binary compatability. Not sure what these changes were > > trying to accomplish...) > > I was trying to use well defined types that described the > usage and the origin of the definition. > > I'm happy to use "unsigned short" or whatever works better. > Please send a patch.
Sure thing:
--- a/arch/sparc/include/asm/stat.h +++ b/arch/sparc/include/asm/stat.h @@ -53,8 +53,8 @@ struct stat { ino_t st_ino; mode_t st_mode; short st_nlink; - uid16_t st_uid; - gid16_t st_gid; + unsigned short st_uid; + unsigned short st_gid; unsigned short st_rdev; off_t st_size; time_t st_atime; Signed-off-by: Rob Landley <rob@landley.net>
Rob -- Latency is more important than throughput. It's that simple. - Linus Torvalds
| |