lkml.org 
[lkml]   [2010]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/10] checkstack: fix perlcritic warnings
Stephen Hemminger wrote:
>Turn on strict checking.
>Get rid of prototypes (prototypes are broken in Perl)

NAK, please check perldoc of sort().
The prototype there is needed by sort().

>Fix syntax of declaration.

Yeah, this is fine.

BTW, your $subject needs to be fixed too.


\
 
 \ /
  Last update: 2010-02-20 04:03    [W:0.038 / U:1.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site