Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH 2/8] PCI PM: PCIe PME root port service driver (rev. 5) | Date | Thu, 18 Feb 2010 20:57:52 +0100 |
| |
On Thursday 18 February 2010, Kenji Kaneshige wrote: > Hi, > > I'm sorry for the delayed comments. > > > + > > +/** > > + * pcie_pme_interrupt_enable - Enable/disable PCIe PME interrupt generation. > > + * @dev: PCIe root port or event collector. > > + * @enable: Enable or disable the interrupt. > > + */ > > +static void pcie_pme_interrupt_enable(struct pci_dev *dev, bool enable) > > +{ > > + int rtctl_pos; > > + u16 rtctl; > > + > > + rtctl_pos = pci_find_capability(dev, PCI_CAP_ID_EXP) + PCI_EXP_RTCTL; > > How about > > rtctl_pos = pci_pcie_cap(dev) + PCI_EXP_RTCTL; > > ? > > The pci_pcie_cap() returns PCIe capability offset saved in struct pci_dev. > By using this, we can avoid redundant search in PCI configuration space.
While I agree with the comment, I'd prefer to change this with a separate patch, unless the entire patchset misses the merge window.
Rafael
| |