Messages in this thread | | | Date | Wed, 08 Dec 2010 16:24:14 +0100 | From | Tejun Heo <> | Subject | Re: [Use cpuops V1 05/11] core: Replace __get_cpu_var with __this_cpu_read if not used for an address. |
| |
On 12/07/2010 04:38 PM, Christoph Lameter wrote: > On Tue, 7 Dec 2010, Tejun Heo wrote: > >> Can you please fold this into the original patch and resend? I >> skipped 04, 05 and 09. percpu#for-next now contains other patches. >> >> git://git.kernel.org/pub/scm/linux/kernel/git/tj/percpu.git for-next >> >> Thanks. > > Subject: core: Replace __get_cpu_var with __this_cpu_read if not used for an address. > > __get_cpu_var() can be replaced with this_cpu_read and will then use a single > read instruction with implied address calculation to access the correct per cpu > instance. > > However, the address of a per cpu variable passed to __this_cpu_read() cannot be > determed (since its an implied address conversion through segment prefixes). > Therefore apply this only to uses of __get_cpu_var where the addres of the > variable is not used. > > Cc: Pekka Enberg <penberg@cs.helsinki.fi> > Cc: Hugh Dickins <hughd@google.com> > Cc: Thomas Gleixner <tglx@linutronix.de> > Signed-off-by: Christoph Lameter <cl@linux.com>
Applied. Thanks.
-- tejun
| |