Messages in this thread | | | Date | Tue, 07 Dec 2010 16:21:50 +0100 | From | Tejun Heo <> | Subject | Re: [Use cpuops V1 05/11] core: Replace __get_cpu_var with __this_cpu_read if not used for an address. |
| |
Hello, again.
On 12/07/2010 03:51 PM, Christoph Lameter wrote: > On Tue, 7 Dec 2010, Tejun Heo wrote: > >>> if (&per_cpu(tasklet_hi_vec, cpu).head != per_cpu(tasklet_hi_vec, cpu).tail) { >>> - *__get_cpu_var(tasklet_hi_vec).tail = per_cpu(tasklet_hi_vec, cpu).head; >>> - __get_cpu_var(tasklet_hi_vec).tail = per_cpu(tasklet_hi_vec, cpu).tail; >>> + *__this_cpuo_read(tasklet_hi_vec.tail) = per_cpu(tasklet_hi_vec, cpu).head; >>> + __this_cpu_write(tasklet_hi_vec.tail, per_cpu(tasklet_hi_vec, cpu).tail; >> >> I don't think __this_cpuo_read() would build. > > A CONFIG_HOTPLUG_CPU section. > > Fix up CONFIG_HOTPLUG_CPU compilation > > Signed-off-by: Christoph Lameter <cl@linux.com>
Can you please fold this into the original patch and resend? I skipped 04, 05 and 09. percpu#for-next now contains other patches.
git://git.kernel.org/pub/scm/linux/kernel/git/tj/percpu.git for-next
Thanks.
-- tejun
| |