| From | Tejun Heo <> | Subject | [PATCH 02/16] signal: fix CLD_CONTINUED notification target | Date | Mon, 6 Dec 2010 17:56:50 +0100 |
| |
CLD_CONTINUED notification code calls do_notify_parent_cldstop() with its group_leader; however, do_notify_parent_cldstop() already uses the group_leader for non-ptraced notifications. The duplicate ->group_leader dereferencing is unnecessary and leads to incorrectly notifying the group_leader's ptracer of CLD_CONTINUED from a different task in the group. Fix it.
Signed-off-by: Tejun Heo <tj@kernel.org> Cc: Oleg Nesterov <oleg@redhat.com> Cc: Roland McGrath <roland@redhat.com> --- kernel/signal.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/signal.c b/kernel/signal.c index fe004b5..0411131 100644 --- a/kernel/signal.c +++ b/kernel/signal.c @@ -1867,7 +1867,7 @@ relock: if (why) { read_lock(&tasklist_lock); - do_notify_parent_cldstop(current->group_leader, why); + do_notify_parent_cldstop(current, why); read_unlock(&tasklist_lock); } goto relock; -- 1.7.1
|