| Date | Tue, 21 Dec 2010 18:04:16 +0100 | From | Tejun Heo <> | Subject | Re: [PATCH 06/16] signal: fix premature completion of group stop when interfered by ptrace |
| |
On Mon, Dec 20, 2010 at 04:00:18PM +0100, Oleg Nesterov wrote: > On 12/06, Tejun Heo wrote: > > > > +static bool task_participate_group_stop(struct task_struct *task) > > +{ > > + struct signal_struct *sig = task->signal; > > + bool consume = task->group_stop & GROUP_STOP_CONSUME; > > + > > + task_clear_group_stop(task); > > + > > + if (!consume) > > + return false; > > + > > + task->group_stop &= ~GROUP_STOP_CONSUME; > > Minor nit, GROUP_STOP_CONSUME was already cleared by task_clear_group_stop().
Thanks. Dropped.
-- tejun
|