lkml.org 
[lkml]   [2010]   [Dec]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/9] ASoC: codecs: Fix register cache incoherencies
On 12/24/2010 03:57 PM, Mark Brown wrote:
> > On Fri, Dec 24, 2010 at 02:47:55PM +0100, Lars-Peter Clausen wrote:
>> >> The multi-component patch(commit f0fba2ad1) introduced a generic register cache
>> >> framework. Most of the drivers where converted to use this new framework. But
> >
> > No it didn't - soc-cache.c has been present since the middle of 2009.
Hm. Ok, you are right, I've should have checked more closely. Only the allocation of
the register cache was moved from the drivers to the core.

So the commit messages should have been along the lines of:
The multi-component patch(commit f0fba2ad1) moved the alloction of the
register cache from drivers to the ASoC core. While most of the drivers were
converted to respect this change, some still maintain their own register
cache besides the one used and allocated by the core.
Thus the device ends up with two from each other incoherent caches, which
can lead to undefined behaviour.

If there are no other issues with this series, I'll resend it with adjusted commit
messages in a few days.

- Lars


\
 
 \ /
  Last update: 2010-12-24 16:41    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site