[lkml]   [2010]   [Dec]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 3/9] ASoC: codecs: wm8523: Fix register cache incoherency
On Fri, Dec 24, 2010 at 02:47:58PM +0100, Lars-Peter Clausen wrote:

> /* Change some default settings - latch VU and enable ZC */
> - wm8523->reg_cache[WM8523_DAC_GAINR] |= WM8523_DACR_VU;
> - wm8523->reg_cache[WM8523_DAC_CTRL3] |= WM8523_ZC;
> + reg_cache[WM8523_DAC_GAINR] |= WM8523_DACR_VU;
> + reg_cache[WM8523_DAC_CTRL3] |= WM8523_ZC;

All the drivers where you're making this substitution should in
principle be changed to use snd_soc_update_bits() since we now have
support for multiple cache memory formats so may not have this flat in
memory structure, though for the sake of getting the fixes in it's
probably best to ignore that and fix it up later.

 \ /
  Last update: 2010-12-24 17:01    [W:0.049 / U:6.744 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site