Messages in this thread Patch in this message | | | Date | Sat, 30 Oct 2010 21:23:14 +0200 (CEST) | From | Jesper Juhl <> | Subject | [PATCH] AMD Microcode: Prefer vzalloc() over calls to vmalloc()+memset() |
| |
Hi,
We don't have to do memset() ourselves after vmalloc() when we have vzalloc(), so change that in arch/x86/kernel/microcode_amd.c::get_next_ucode().
Please CC me on replies.
Signed-off-by: Jesper Juhl <jj@chaosbits.net> --- compile tested only.
microcode_amd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/x86/kernel/microcode_amd.c b/arch/x86/kernel/microcode_amd.c index e1af7c0..d46e805 100644 --- a/arch/x86/kernel/microcode_amd.c +++ b/arch/x86/kernel/microcode_amd.c @@ -183,9 +183,8 @@ get_next_ucode(const u8 *buf, unsigned int size, unsigned int *mc_size) return NULL; } - mc = vmalloc(UCODE_MAX_SIZE); + mc = vzalloc(UCODE_MAX_SIZE); if (mc) { - memset(mc, 0, UCODE_MAX_SIZE); if (get_ucode_data(mc, buf + UCODE_CONTAINER_SECTION_HDR, total_size)) { vfree(mc);
-- Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/ Plain text mails only, please http://www.expita.com/nomime.html Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
| |