Messages in this thread Patch in this message | | | Date | Wed, 20 Oct 2010 18:15:27 +0300 | From | Felipe Balbi <> | Subject | Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff |
| |
hi,
On Wed, Oct 20, 2010 at 09:52:06AM -0500, Felipe Contreras wrote: >TWL4030_USB is inside drivers/usb/Kconfig and drivers/usb/otg/Kconfig, >which means in order to achieve the same on the board config you would >have to do: > >default y if USB_SUPPORT && (USB || USB_GADGET) && ARCH_OMAP3 > >Seems to be more convoluted to me. > >Besides, I think TWL4030_USB and the full description of it doesn't >give any hints to the people reading drivers/usb/otg/Kconfig what is >it used for. 'default y if ARCH_OMAP3' achieves that.
no it doesn't. No user will 'cat drivers/usb/otg/Kconfig | grep -A 10 TWL4030' and check the 'default y if ARCH_OMAP3
if you think help is not enough, fix help.
>Plus, there is no big change: > >config USB_MUSB_HDRC >- select TWL4030_USB if MACH_OMAP_3430SDP > >config TWL4030_USB >+ default y if ARCH_OMAP3 >
what's the problem with:
diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig index ab784bf..3af9580 100644 --- a/arch/arm/mach-omap2/Kconfig +++ b/arch/arm/mach-omap2/Kconfig @@ -215,6 +215,7 @@ config MACH_NOKIA_RX51 depends on ARCH_OMAP3 default y select OMAP_PACKAGE_CBB + select TWL4030_USB config MACH_OMAP_ZOOM2 bool "OMAP3 Zoom2 board" -- balbi
| |