Messages in this thread | | | Date | Wed, 20 Oct 2010 17:52:06 +0300 | Subject | Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff | From | Felipe Contreras <> |
| |
On Wed, Oct 20, 2010 at 3:54 PM, Felipe Balbi <balbi@ti.com> wrote: > On Wed, Oct 20, 2010 at 04:23:13AM -0500, Felipe Contreras wrote: >> >> Ok, but USB_OMAP is not supposed to work on the N900? (I tried and it >> didn't) > > ooooh, that's old. That's from the omap1. It's the old omap_udc.c
Ok, then the dependency should be ARCH_OMAP1, not ARCH_OMAP.
>> I don't think so, because people might not want USB at all. The ideal >> case would be for USB_GADGET_MUSB_HDRC to be selected automatically >> when the user selects USB and USB_GADGET, but that's not happening >> because USB_GADGET_OMAP is selected first (all the dependencies are >> met). > > And how is that different from: > > default y if ARCH_OMAP3 ? If you don't want USB at all, you'll disable > it by hand, the default is on. Select on board Kconfig.
TWL4030_USB is inside drivers/usb/Kconfig and drivers/usb/otg/Kconfig, which means in order to achieve the same on the board config you would have to do:
default y if USB_SUPPORT && (USB || USB_GADGET) && ARCH_OMAP3
Seems to be more convoluted to me.
Besides, I think TWL4030_USB and the full description of it doesn't give any hints to the people reading drivers/usb/otg/Kconfig what is it used for. 'default y if ARCH_OMAP3' achieves that.
Plus, there is no big change:
config USB_MUSB_HDRC - select TWL4030_USB if MACH_OMAP_3430SDP
config TWL4030_USB + default y if ARCH_OMAP3
-- Felipe Contreras
| |