Messages in this thread Patch in this message | | | Date | Wed, 13 Oct 2010 13:59:03 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | [BUGFIX][PATCH] fix return value of scan_lru_pages in memory unplug |
| |
CC'ed to stable tree...maybe all kernel has this bug. But this may not very critical because we've got no report until now.
== From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
scan_lru_pages returns pfn. So, it's type should be "unsigned long" not "int".
Note: I guess this has been work until now because memory hotplug tester's machine has not very big memory.... physical address < 32bit << PAGE_SHIFT.
Reported-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> --- mm/memory_hotplug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Index: mmotm-1008/mm/memory_hotplug.c =================================================================== --- mmotm-1008.orig/mm/memory_hotplug.c +++ mmotm-1008/mm/memory_hotplug.c @@ -646,7 +646,7 @@ static int test_pages_in_a_zone(unsigned * Scanning pfn is much easier than scanning lru list. * Scan pfn from start to end and Find LRU page. */ -int scan_lru_pages(unsigned long start, unsigned long end) +unsigned long scan_lru_pages(unsigned long start, unsigned long end) { unsigned long pfn; struct page *page;
| |