lkml.org 
[lkml]   [2010]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH -mmotm-2010-01-06-14-34] Count minor fault in break_ksm
    We have counted task's maj/min fault after handle_mm_fault.
    break_ksm misses that.

    I wanted to check by VM_FAULT_ERROR.
    But now break_ksm doesn't handle HWPOISON error.

    Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
    CC: Hugh Dickins <hugh.dickins@tiscali.co.uk>
    CC: Izik Eidus <ieidus@redhat.com>
    ---
    mm/ksm.c | 6 +++++-
    1 files changed, 5 insertions(+), 1 deletions(-)

    diff --git a/mm/ksm.c b/mm/ksm.c
    index 56a0da1..3a1fda4 100644
    --- a/mm/ksm.c
    +++ b/mm/ksm.c
    @@ -367,9 +367,13 @@ static int break_ksm(struct vm_area_struct *vma, unsigned long addr)
    page = follow_page(vma, addr, FOLL_GET);
    if (!page)
    break;
    - if (PageKsm(page))
    + if (PageKsm(page)) {
    ret = handle_mm_fault(vma->vm_mm, vma, addr,
    FAULT_FLAG_WRITE);
    + if (!(ret & (VM_FAULT_SIGBUS | VM_FAULT_OOM)
    + || current->flags & PF_KTHREAD))
    + current->min_flt++;
    + }
    else
    ret = VM_FAULT_WRITE;
    put_page(page);
    --
    1.5.6.3


    --
    Kind regards,
    Minchan Kim


    \
     
     \ /
      Last update: 2010-01-11 03:51    [W:0.032 / U:0.476 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site