[lkml]   [2009]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 1/8] mm: munlock use follow_page
    On Tue, Sep 8, 2009 at 6:29 AM, Hugh Dickins <> wrote:
    > Hiroaki Wakabayashi points out that when mlock() has been interrupted
    > by SIGKILL, the subsequent munlock() takes unnecessarily long because
    > its use of __get_user_pages() insists on faulting in all the pages
    > which mlock() never reached.
    > It's worse than slowness if mlock() is terminated by Out Of Memory kill:
    > the munlock_vma_pages_all() in exit_mmap() insists on faulting in all the
    > pages which mlock() could not find memory for; so innocent bystanders are
    > killed too, and perhaps the system hangs.
    > __get_user_pages() does a lot that's silly for munlock(): so remove the
    > munlock option from __mlock_vma_pages_range(), and use a simple loop of
    > follow_page()s in munlock_vma_pages_range() instead; ignoring absent
    > pages, and not marking present pages as accessed or dirty.
    > (Change munlock() to only go so far as mlock() reached?  That does not
    > work out, given the convention that mlock() claims complete success even
    > when it has to give up early - in part so that an underlying file can be
    > extended later, and those pages locked which earlier would give SIGBUS.)
    > Signed-off-by: Hugh Dickins <>
    > Cc:
    Reviewed-by: Minchan Kim <>
    It looks better than old Hiroaki's one.

    Kind regards,
    Minchan Kim
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2009-09-09 18:03    [W:0.021 / U:2.044 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site