Messages in this thread | | | Date | Tue, 29 Sep 2009 12:25:59 +0200 | From | Philippe De Muyter <> | Subject | Re: [PATCH RFC] vfat and Simon_&_Garfunkel-Wednesday_Morning,_3_a.m. |
| |
Hi Ogawa,
On Tue, Sep 29, 2009 at 07:05:27PM +0900, OGAWA Hirofumi wrote: > Philippe De Muyter <phdm@macqel.be> writes: > > > I have an IOMEGA home network hard disk that I can connect either by > > ethernet (ftp or cifs) or by USB. Because of the ftp server mode > > firmware, I must keep it formatted as a vfat filesystem. > > > > I have copied my music files on it using the ftp mode. Using the same > > ftp mode, I can also retrieve my music files without problem, and > > when I list them, they have the exact names that they had on my linux > > ext3 partition. > > > > When I connected this disk via USB, now relying on the vfat module > > of linux, there were some directories that I could not reread. The > > common factor of these directories names is that they end with one or > > more dots, e.g. > > > > Simon_&_Garfunkel-Wednesday_Morning,_3_a.m. > > > > If I issue the `ls' or `find' command, I get this strange message : > > > > find: ./Simon_&_Garfunkel-Wednesday_Morning,_3_a.m.: No such file or directory > > > > Adding printk's in `fat_search_long' revealed that on this disk, the > > file/directory NAMES ENDING WITH DOTS ARE STORED WITH THEIR TRAILING DOTS. > > > > Here is a patch sketch that makes accessing my > > Simon_&_Garfunkel-Wednesday_Morning,_3_a.m. directory possible, but I > > don't know if storing long filenames ending with dot's should not also > > be fixed. > > IIRC, Windows stripped the trailing ".". That filename can be read/used on > Windows?
Sorry I don't use MS-Windows. I'll try to find someone who does.
But, risking repeating myself, the firmware of the IOMEGA disk (via the ftp interface) presents the filenames with the trailing dots.
> If it can be read, I think we should consider to remove > vfat_striptail_len() (at least for lookup path), more investigation > would be needed though.
That's what my patch does actually. Maybe it should depend of the length of the filename, though.
Thanks
Philippe
| |