Messages in this thread Patch in this message | | | Date | Mon, 21 Sep 2009 18:22:11 +0200 | From | Ingo Molnar <> | Subject | Re: [GIT PULL] tracing fixes |
| |
* Linus Torvalds <torvalds@linux-foundation.org> wrote:
> On Mon, 21 Sep 2009, Ingo Molnar wrote: > > > > Christoph Hellwig (1): > > tracing: Remove markers > > This seems to result in: > > kernel/module.c:2951: warning: ?struct marker? declared inside parameter list > kernel/module.c:2951: warning: its scope is only this definition or declaration, which is probably not what you want > > Hmm? Incomplete removal?
Hm, yes, you are right, we missed that. I noticed the modpost dependency:
http://marc.info/?l=linux-kernel&m=125326944223679&w=2
but thought that it's safe and didnt notice that dangling module_layout() reference and the build warning it generates in the kernel.
I _think_ the patch below should do the trick - module_layout() appears to be an artificial symbol with 'significant' symbols listed in its argument list so that it gets a proper signature. Removing the marker symbol should thus be the solution, but i'm not 100% sure. Thoughts?
Ingo
diff --git a/kernel/module.c b/kernel/module.c index b6ee424..392eb3d 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -2947,7 +2947,6 @@ void module_layout(struct module *mod, struct modversion_info *ver, struct kernel_param *kp, struct kernel_symbol *ks, - struct marker *marker, struct tracepoint *tp) { }
| |