Messages in this thread Patch in this message | | | Date | Wed, 23 Sep 2009 09:04:34 GMT | From | tip-bot for Ingo Molnar <> | Subject | [tip:tracing/urgent] modules, tracing: Remove stale struct marker signature from module_layout() |
| |
Commit-ID: 115e8a288252ef748f34f8b7c1115c563d702eda Gitweb: http://git.kernel.org/tip/115e8a288252ef748f34f8b7c1115c563d702eda Author: Ingo Molnar <mingo@elte.hu> AuthorDate: Mon, 21 Sep 2009 18:22:11 +0200 Committer: Ingo Molnar <mingo@elte.hu> CommitDate: Wed, 23 Sep 2009 10:34:21 +0200
modules, tracing: Remove stale struct marker signature from module_layout()
Linus reported this new build warning:
kernel/module.c:2951: warning: ?struct marker? declared inside parameter list kernel/module.c:2951: warning: its scope is only this definition or declaration, which is probably not what you want
Caused by:
fc53776: tracing: Remove markers
module_layout() is an artificial symbol with 'significant' symbols listed in its argument list so that it gets a proper argument types signature that modversions can pick up to decide whether a module is version-compatible or not. If these dont match then we wont even look at a module.
Remove the stale marker symbol.
Reported-by: Linus Torvalds <torvalds@linux-foundation.org> LKML-Reference: <alpine.LFD.2.01.0909210908020.4950@localhost.localdomain> Cc: Christoph Hellwig <hch@lst.de> Cc: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Rusty Russell <rusty@rustcorp.com.au> Signed-off-by: Ingo Molnar <mingo@elte.hu>
--- kernel/module.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/kernel/module.c b/kernel/module.c index b6ee424..392eb3d 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -2947,7 +2947,6 @@ void module_layout(struct module *mod, struct modversion_info *ver, struct kernel_param *kp, struct kernel_symbol *ks, - struct marker *marker, struct tracepoint *tp) { }
| |