lkml.org 
[lkml]   [2009]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectmISDN: potential null dereference in dsp_cmx_send_member()
Hello,

I am testing a source analysis tool (http://repo.or.cz/w/smatch.git)
and it generates a warning in dsp_cmx_send_member().

The problem is that on line 1327 we verify that dsp->conf is non null but
on line 1329 we assume that it is non null and dereference it without
checking.

drivers/isdn/mISDN/dsp_cmx.c
1327 if (dsp->conf && dsp->conf->software && dsp->conf->hardware)
1328 tx_data_only = 1;
1329 if (dsp->conf->software && dsp->echo.hardware)
1330 tx_data_only = 1;

regards,
dan carpenter


\
 
 \ /
  Last update: 2009-08-07 14:17    [W:0.023 / U:0.872 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site