Messages in this thread Patch in this message | | | Date | Fri, 14 Aug 2009 13:25:29 +0200 | From | Martin Schwidefsky <> | Subject | [patch 12/34] drivers/s390: put NULL test before dereference |
| |
From: Julia Lawall <julia@diku.dk>
If the NULL test on block is needed, it should be before the dereference of the base field.
The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @r@ expression E1,E2; identifier fld; statement S1,S2; @@
E1 = E2->fld; ( if (E1 == NULL) S1 else S2 | *if (E2 == NULL) S1 else S2 ) // </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com> ---
drivers/s390/block/dasd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Index: quilt-2.6/drivers/s390/block/dasd.c =================================================================== --- quilt-2.6.orig/drivers/s390/block/dasd.c +++ quilt-2.6/drivers/s390/block/dasd.c @@ -2133,9 +2133,9 @@ static int dasd_getgeo(struct block_devi struct dasd_device *base; block = bdev->bd_disk->private_data; - base = block->base; if (!block) return -ENODEV; + base = block->base; if (!base->discipline || !base->discipline->fill_geometry) -- blue skies, Martin.
"Reality continues to ruin my life." - Calvin.
| |