lkml.org 
[lkml]   [2009]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 03/34] cio: consolidate subchannel intparm reset
    From: Peter Oberparleiter <peter.oberparleiter@de.ibm.com>

    Ensure that the hardware interruption parameter for a subchannel is
    reset when the associated subchannel data structure is freed.

    Signed-off-by: Peter Oberparleiter <peter.oberparleiter@de.ibm.com>
    Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
    ---

    drivers/s390/cio/css.c | 3 +++
    drivers/s390/cio/device.c | 10 ----------
    2 files changed, 3 insertions(+), 10 deletions(-)

    Index: quilt-2.6/drivers/s390/cio/css.c
    ===================================================================
    --- quilt-2.6.orig/drivers/s390/cio/css.c
    +++ quilt-2.6/drivers/s390/cio/css.c
    @@ -170,6 +170,9 @@ css_subchannel_release(struct device *de

    sch = to_subchannel(dev);
    if (!cio_is_console(sch->schid)) {
    + /* Reset intparm to zeroes. */
    + sch->config.intparm = 0;
    + cio_commit_config(sch);
    kfree(sch->lock);
    kfree(sch);
    }
    Index: quilt-2.6/drivers/s390/cio/device.c
    ===================================================================
    --- quilt-2.6.orig/drivers/s390/cio/device.c
    +++ quilt-2.6/drivers/s390/cio/device.c
    @@ -1026,9 +1026,6 @@ static void ccw_device_call_sch_unregist
    return;
    sch = to_subchannel(cdev->dev.parent);
    css_sch_device_unregister(sch);
    - /* Reset intparm to zeroes. */
    - sch->config.intparm = 0;
    - cio_commit_config(sch);
    /* Release cdev reference for workqueue processing.*/
    put_device(&cdev->dev);
    /* Release subchannel reference for local processing. */
    @@ -1212,9 +1209,6 @@ static void io_subchannel_do_unreg(struc

    sch = container_of(work, struct subchannel, work);
    css_sch_device_unregister(sch);
    - /* Reset intparm to zeroes. */
    - sch->config.intparm = 0;
    - cio_commit_config(sch);
    put_device(&sch->dev);
    }

    @@ -1690,10 +1684,6 @@ static int io_subchannel_sch_event(struc
    spin_unlock_irqrestore(sch->lock, flags);
    css_sch_device_unregister(sch);
    spin_lock_irqsave(sch->lock, flags);
    -
    - /* Reset intparm to zeroes. */
    - sch->config.intparm = 0;
    - cio_commit_config(sch);
    break;
    case REPROBE:
    ccw_device_trigger_reprobe(cdev);
    --
    blue skies,
    Martin.

    "Reality continues to ruin my life." - Calvin.



    \
     
     \ /
      Last update: 2009-08-14 13:31    [W:0.024 / U:151.104 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site