| Date | Wed, 12 Aug 2009 12:33:09 -0400 | From | Masami Hiramatsu <> | Subject | Re: [GIT PULL] tracing: Syscalls trace events + perf support |
| |
Hi Frederic and Jason,
Frederic Weisbecker wrote: > Frederic Weisbecker (3): > tracing: Add ftrace event call parameter to its field descriptor handler
> Jason Baron (12): > tracing: Add ftrace_event_call void * 'data' field
Both of you added a parameter to ftrace_event_call for passing sycall name (call->data) to handlers, but one passes 'ftrace_event_call *' and another passes 'void *'. It seems not enough unified.
And also, I'm now updating my patch for 'dynamic ftrace_event_call' http://lkml.org/lkml/2009/7/24/234 which adds 'ftrace_event_call *' for all handlers.
I think passing 'ftrace_event_call *' is more generic way to do that. What would you think about that?
Thank you,
-- Masami Hiramatsu
Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division
e-mail: mhiramat@redhat.com
|