lkml.org 
[lkml]   [2009]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [GIT PULL] tracing: Syscalls trace events + perf support


    Masami Hiramatsu wrote:
    > Hi Frederic and Jason,
    >
    > Frederic Weisbecker wrote:
    >> Frederic Weisbecker (3):
    >> tracing: Add ftrace event call parameter to its field descriptor handler
    >
    >> Jason Baron (12):
    >> tracing: Add ftrace_event_call void * 'data' field
    >
    > Both of you added a parameter to ftrace_event_call for passing
    > sycall name (call->data) to handlers, but one passes 'ftrace_event_call *'
    > and another passes 'void *'. It seems not enough unified.
    >
    > And also, I'm now updating my patch for 'dynamic ftrace_event_call'
    > http://lkml.org/lkml/2009/7/24/234
    > which adds 'ftrace_event_call *' for all handlers.
    >
    > I think passing 'ftrace_event_call *' is more generic way
    > to do that. What would you think about that?

    Hmm, I changed my mind that passing 'void *' is enough, since
    all other fields of ftrace_event_call will be handled in
    trace_events.c.

    Thank you,


    --
    Masami Hiramatsu

    Software Engineer
    Hitachi Computer Products (America), Inc.
    Software Solutions Division

    e-mail: mhiramat@redhat.com



    \
     
     \ /
      Last update: 2009-08-12 19:01    [W:0.022 / U:0.680 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site