Messages in this thread Patch in this message | | | From | Jeff Layton <> | Subject | [PATCH 2/3] vfs: remove redundant position check in do_sendfile | Date | Mon, 10 Aug 2009 08:17:42 -0400 |
| |
As Johannes Weiner pointed out, one of the range checks in do_sendfile is redundant and is already checked in rw_verify_area.
Signed-off-by: Jeff Layton <jlayton@redhat.com> --- fs/read_write.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/fs/read_write.c b/fs/read_write.c index 6c8c55d..3ac2898 100644 --- a/fs/read_write.c +++ b/fs/read_write.c @@ -839,9 +839,6 @@ static ssize_t do_sendfile(int out_fd, int in_fd, loff_t *ppos, max = min(in_inode->i_sb->s_maxbytes, out_inode->i_sb->s_maxbytes); pos = *ppos; - retval = -EINVAL; - if (unlikely(pos < 0)) - goto fput_out; if (unlikely(pos + count > max)) { retval = -EOVERFLOW; if (pos >= max) -- 1.6.0.6
| |