Messages in this thread | | | Date | Mon, 10 Aug 2009 10:08:18 -0400 | From | Jeff Layton <> | Subject | Re: [PATCH 1/3] vfs: make get_sb_pseudo set s_maxbytes to value that can be cast to signed |
| |
On Mon, 10 Aug 2009 09:49:50 -0400 Christoph Hellwig <hch@infradead.org> wrote:
> On Mon, Aug 10, 2009 at 08:17:41AM -0400, Jeff Layton wrote: > > get_sb_pseudo sets s_maxbytes to ~0ULL which becomes negative when cast > > to a signed value. Fix it to use MAX_LFS_FILESIZE which casts properly > > to a positive signed value. > > > > Signed-off-by: Jeff Layton <jlayton@redhat.com> > > Reviewed-by: Johannes Weiner <hannes@cmpxchg.org> > > Acked-by: Steve French <smfrench@gmail.com> > > Looks good, and I think it would be very good to still gets this into > 2.6.31. > > Reviewed-by: Christoph Hellwig <hch@lst.de> >
Agreed. The other two should probably go in early 2.6.32 (assuming they're ok).
-- Jeff Layton <jlayton@redhat.com>
| |