lkml.org 
[lkml]   [2009]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: + task_struct-cleanup-make-binfmt-module-get-and-put-per-signal_struct .patch added to -mm tree
On 07/22, Andrew Morton wrote:
>
> Subject: task_struct cleanup: make binfmt module get and put per signal_struct
> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
>
> The binfmt is a member of signal_struct, so it can be handled per
> signal_struct instead of task_struct.

Both patches look good to me. But perhaps the changelog for this patch
should document the user-visible change,

> @@ -888,6 +892,8 @@ void __cleanup_signal(struct signal_stru
> {
> thread_group_cputime_free(sig);
> tty_kref_put(sig->tty);
> + if (sig->binfmt)
> + module_put(sig->binfmt->module);
> kmem_cache_free(signal_cachep, sig);
> }

This means that a zombie task still holds a reference to ->binfmt, until
it is reaped.


Or. we can do module_put() earlier, in do_exit() under "if (group_dead)".
(in that case we should also modify copy_process() path).

Oleg.



\
 
 \ /
  Last update: 2009-07-22 23:45    [W:0.028 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site