Messages in this thread Patch in this message | | | Date | Thu, 23 Jul 2009 00:52:59 +0400 | From | Cyrill Gorcunov <> | Subject | [PATCH -tip] x86,apic - drop redundant bit assignment |
| |
cpu_has_apic has already investigated boot_cpu_data X86_FEATURE_APIC bit for being clear if condition is triggered. So there is no need to clear this bit second time.
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org> ---
Please review. Is there some unobvious reason was before to clear this bit? This snippet already here since long ago. Perhaps I miss something?
arch/x86/kernel/apic/apic.c | 1 - 1 file changed, 1 deletion(-)
Index: linux-2.6.git/arch/x86/kernel/apic/apic.c ===================================================================== --- linux-2.6.git.orig/arch/x86/kernel/apic/apic.c +++ linux-2.6.git/arch/x86/kernel/apic/apic.c @@ -1651,7 +1651,6 @@ int __init APIC_init_uniprocessor(void) APIC_INTEGRATED(apic_version[boot_cpu_physical_apicid])) { pr_err("BIOS bug, local APIC 0x%x not detected!...\n", boot_cpu_physical_apicid); - clear_cpu_cap(&boot_cpu_data, X86_FEATURE_APIC); return -1; } #endif
| |