Messages in this thread | | | Subject | Re: [RFC patch] disable the assumption of apic_is_clustered_box for cores >= 6 | From | Suresh Siddha <> | Date | Thu, 02 Jul 2009 12:04:42 -0700 |
| |
On Mon, 2009-06-29 at 19:53 -0700, Luming Yu wrote: > Hello, > > We have to disable the assumption of apic_is_clustered_box that assumes high > 4bits of 8 bit APIC ID was cluster id, which is just the function's guess. > On a normal 4-socket system with >6cores Processor and HT enabled, we hit the > limitation of the guess and failed. Have to disable the guess on any > cores > 6 system. > > Without this patch, we can't use good TSC on any SMP system with 48+ logical CPU
This patch doesn't seem to be the right fix. BTW, it appears that Yinghai's patch in mainline appear to address this issue already. Did you check if the mainline still has the issue that you are trying to fix here?
commit e0e42142bab96404de535cceb85d6533d5ad7942 Author: Yinghai Lu <yinghai@kernel.org> Date: Sun Apr 26 23:39:38 2009 -0700
x86: Use dmi check in apic_is_clustered() on 64-bit to mark the TSC unstable
thanks, suresh
| |