lkml.org 
[lkml]   [2009]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RFC patch] disable the assumption of apic_is_clustered_box for cores >= 6
From
On Fri, Jul 3, 2009 at 3:04 AM, Suresh Siddha<suresh.b.siddha@intel.com> wrote:
> On Mon, 2009-06-29 at 19:53 -0700, Luming Yu wrote:
>> Hello,
>>
>> We have to disable the assumption of apic_is_clustered_box that assumes high
>> 4bits of 8 bit APIC ID was cluster id, which is just the function's guess.
>> On a normal 4-socket system with >6cores Processor and HT enabled, we hit the
>> limitation of the guess and failed. Have to disable the guess on any
>> cores > 6 system.
>>
>> Without this patch, we can't use good TSC on any SMP system with 48+ logical CPU
>
> This patch doesn't seem to be the right fix. BTW, it appears that
> Yinghai's patch in mainline appear to address this issue already. Did
> you check if the mainline still has the issue that you are trying to fix
> here?

Oh.. my testing kernel is still -rc6. The patch should fix the problem.
Thanks for the pointer. I believe I have heard of this patch, but don't know
why I didn't check that first before spending time on this fix,
although this patch didn't take
too much time, but does create some noise. I'm sorry about that.


\
 
 \ /
  Last update: 2009-07-03 04:39    [W:0.041 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site