lkml.org 
[lkml]   [2009]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] x86: fix dummy apic read/write warning
    ingo got
    [ 0.000000] Using APIC driver default
    [ 0.000000] SMP: Allowing 1 CPUs, 0 hotplug CPUs
    [ 0.000000] Local APIC disabled by BIOS -- you can enable it with "lapic"
    [ 0.000000] APIC: disable apic facility
    [ 0.000000] ------------[ cut here ]------------
    [ 0.000000] WARNING: at arch/x86/kernel/apic/apic.c:254 native_apic_read_dummy+0x2d/0x3b()
    [ 0.000000] Hardware name: HP OmniBook PC

    we have wrong check in dummy read and write.
    [we only test on system that have APIC with "disableapic"...]

    Signed-off-by: yinghai Lu <yinghai@kernel.org>

    ---
    arch/x86/kernel/apic/apic.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    Index: linux-2.6/arch/x86/kernel/apic/apic.c
    ===================================================================
    --- linux-2.6.orig/arch/x86/kernel/apic/apic.c
    +++ linux-2.6/arch/x86/kernel/apic/apic.c
    @@ -246,12 +246,12 @@ static int modern_apic(void)
    */
    static void native_apic_write_dummy(u32 reg, u32 v)
    {
    - WARN_ON_ONCE((cpu_has_apic || !disable_apic));
    + WARN_ON_ONCE((cpu_has_apic && !disable_apic));
    }

    static u32 native_apic_read_dummy(u32 reg)
    {
    - WARN_ON_ONCE((cpu_has_apic || !disable_apic));
    + WARN_ON_ONCE((cpu_has_apic && !disable_apic));
    return 0;
    }



    \
     
     \ /
      Last update: 2009-06-07 00:21    [W:0.023 / U:62.964 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site