Messages in this thread Patch in this message | | | Date | Mon, 15 Jun 2009 00:08:22 -0700 | From | Arjan van de Ven <> | Subject | [PATCH] WARN(): add a \n to the message printk |
| |
From 14cc1a7592e46a8b57081f90d7d54ab274ab7610 Mon Sep 17 00:00:00 2001 From: Arjan van de Ven <arjan@linux.intel.com> Date: Mon, 15 Jun 2009 00:05:39 -0700 Subject: [PATCH] WARN(): add a \n to the message printk
many (most) users of WARN() don't have a \n at the end of their string; as is understandable from the API usage point of view. But this means that the backend needs to add this \n or the warning message gets corrupted (as is seen by kerneloops.org).
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com> --- kernel/panic.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/kernel/panic.c b/kernel/panic.c index 984b3ec..08ce451 100644 --- a/kernel/panic.c +++ b/kernel/panic.c @@ -355,8 +355,10 @@ static void warn_slowpath_common(const char *file, int line, void *caller, struc if (board) printk(KERN_WARNING "Hardware name: %s\n", board); - if (args) + if (args) { vprintk(args->fmt, args->args); + printk("\n"); + } print_modules(); dump_stack(); -- 1.6.0.6
-- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org
| |