Messages in this thread | | | Date | Sat, 13 Jun 2009 22:31:00 +0200 | From | Ingo Molnar <> | Subject | Re: -git tree build failure #2: drivers/net/cnic.c:2520: error: implicit declarati on of function ‘ symbol get’ |
| |
* Linus Torvalds <torvalds@linux-foundation.org> wrote:
> > --- a/drivers/net/cnic.c > > +++ b/drivers/net/cnic.c > > @@ -25,6 +25,8 @@ > > #include <linux/delay.h> > > #include <linux/ethtool.h> > > #include <linux/if_vlan.h> > > +#include <linux/module.h> > > + > > That makes no sense. > > Look at the first #include in the file - it already includes > <linux/module.h>. > > Why do we need to do it twice?
Hm, indeed ... weird - i pasted that error message from a direct reproducer and when i added module.h the build failure disappeared. James - please discard the second patch for now, there's something fishy here.
I tried to reproduce this second problem with the configs i saved/sent and failed. I'll now started tests with just Randy's fix.
Ingo
| |