Messages in this thread | | | Date | Sat, 13 Jun 2009 13:11:25 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: -git tree build failure #2: drivers/net/cnic.c:2520: error: implicit declaration of function ‘ symbol get’ |
| |
On Sat, 13 Jun 2009, Ingo Molnar wrote: > > > I just posted a patch for this to netdev and it was acked by its maintainer. > > Patch is below. > > This solves the first build failure but there's still a second build > failure: > > drivers/net/cnic.c: In function ‘init_bnx2_cnic’: > drivers/net/cnic.c:2520: error: implicit declaration of function ‘__symbol_get’ > drivers/net/cnic.c:2520: warning: assignment makes pointer from integer without a cast > make[1]: *** [drivers/net/cnic.o] Error 1 > make: *** [drivers/net/cnic.o] Error 2 > > This too triggers with the config i sent. The patch below solves it > - but i havent done more testing. > > Ingo > > Signed-off-by: Ingo Molnar <mingo@elte.hu> > > diff --git a/drivers/net/cnic.c b/drivers/net/cnic.c > index 8d74037..49135cc 100644 > --- a/drivers/net/cnic.c > +++ b/drivers/net/cnic.c > @@ -25,6 +25,8 @@ > #include <linux/delay.h> > #include <linux/ethtool.h> > #include <linux/if_vlan.h> > +#include <linux/module.h> > +
That makes no sense.
Look at the first #include in the file - it already includes <linux/module.h>.
Why do we need to do it twice?
Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |