lkml.org 
[lkml]   [2009]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/7] add syscall tracepoints
    * Jason Baron (jbaron@redhat.com) wrote:
    >
    > Introduce a new 'DECLARE_TRACE_REG()' macro, so that tracepoints can associate
    > an external register/unregister function.
    >
    >
    > Signed-off-by: Jason Baron <jbaron@redhat.com>
    >
    > ---
    > include/linux/tracepoint.h | 27 +++++++++++++++++++++++----
    > 1 files changed, 23 insertions(+), 4 deletions(-)
    >
    > diff --git a/include/linux/tracepoint.h b/include/linux/tracepoint.h
    > index 14df7e6..9a3660b 100644
    > --- a/include/linux/tracepoint.h
    > +++ b/include/linux/tracepoint.h
    > @@ -61,7 +61,7 @@ struct tracepoint {
    > * not add unwanted padding between the beginning of the section and the
    > * structure. Force alignment to the same alignment as the section start.
    > */
    > -#define DECLARE_TRACE(name, proto, args) \
    > +#define DECLARE_TRACE_REG(name, proto, args, reg, unreg) \
    > extern struct tracepoint __tracepoint_##name; \
    > static inline void trace_##name(proto) \
    > { \
    > @@ -71,13 +71,29 @@ struct tracepoint {
    > } \
    > static inline int register_trace_##name(void (*probe)(proto)) \
    > { \
    > - return tracepoint_probe_register(#name, (void *)probe); \
    > + int ret; \
    > + void (*func)(void) = (void (*)(void))reg; \
    > + \
    > + ret = tracepoint_probe_register(#name, (void *)probe); \
    > + if (func && !ret) \
    > + func(); \

    I don't see why you need to add this weird interface when all you really
    need to do is to call the function to set the TIF flags explicitly in
    reg_event_syscall_enter when registering a tracepoint.

    Mathieu

    > + return ret; \
    > } \
    > static inline int unregister_trace_##name(void (*probe)(proto)) \
    > { \
    > - return tracepoint_probe_unregister(#name, (void *)probe);\
    > + int ret; \
    > + void (*func)(void) = (void (*)(void))unreg; \
    > + \
    > + ret = tracepoint_probe_unregister(#name, (void *)probe);\
    > + if (func && !ret) \
    > + func(); \
    > + return ret; \
    > }
    >
    > +
    > +#define DECLARE_TRACE(name, proto, args) \
    > + DECLARE_TRACE_REG(name, TP_PROTO(proto), TP_ARGS(args), 0, 0);
    > +
    > #define DEFINE_TRACE(name) \
    > static const char __tpstrtab_##name[] \
    > __attribute__((section("__tracepoints_strings"))) = #name; \
    > @@ -94,7 +110,7 @@ extern void tracepoint_update_probe_range(struct tracepoint *begin,
    > struct tracepoint *end);
    >
    > #else /* !CONFIG_TRACEPOINTS */
    > -#define DECLARE_TRACE(name, proto, args) \
    > +#define DECLARE_TRACE_REG(name, proto, args, reg, unreg) \
    > static inline void _do_trace_##name(struct tracepoint *tp, proto) \
    > { } \
    > static inline void trace_##name(proto) \
    > @@ -108,6 +124,9 @@ extern void tracepoint_update_probe_range(struct tracepoint *begin,
    > return -ENOSYS; \
    > }
    >
    > +#define DECLARE_TRACE(name, proto, args) \
    > + DECLARE_TRACE_REG(name, TP_PROTO(proto), TP_ARGS(args), 0, 0);
    > +
    > #define DEFINE_TRACE(name)
    > #define EXPORT_TRACEPOINT_SYMBOL_GPL(name)
    > #define EXPORT_TRACEPOINT_SYMBOL(name)
    > --
    > 1.6.0.6
    >

    --
    Mathieu Desnoyers
    OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68


    \
     
     \ /
      Last update: 2009-06-13 00:01    [W:0.030 / U:0.064 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site