Messages in this thread | | | Date | Mon, 1 Jun 2009 13:05:47 +0800 | Subject | Re:[RFC/PATCH PATCH 6/6] lockdep: Consider the rw_state of lock while validating the chain. | From | Yong Zhang <> |
| |
<...> >@@ -1767,9 +1773,15 @@ static int validate_chain(struct task_struct *curr, struct lockdep_map *lock, > > if (!ret) > return 0; >+ >+ if (ret != 2 && is_rec_read(hlock->rw_state)) >+ hlock->rw_state |= STATE_FIRST_RECURSIVE_READ; >+ >+ > /* > * Add dependency only if this lock is not the head >- * of the chain, and if it's not a secondary read-lock: >+ * of the chain, and if it's not the first instance of >+ * the recursive read-lock:
This change maybe don't show what you want to say. Maybe it should be "or if it's the first instance of the recursive read-lock."
> */ > if (!chain_head && ret != 2) > if (!check_prevs_add(curr, hlock)) <...>
| |