Messages in this thread | | | Date | Tue, 12 May 2009 12:15:14 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH v2] x86: fix ktermios-termio conversion |
| |
* Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> > My argument was very simple: the patch causes +150 bytes of > > bloat. The try/ex/catch method can help reduce register pressure > > and can reducethe size of code quite visibly. > > My argument is even simpler - its not worth the effort in the > first place. > > I'm sure you could use the same time to shave 150 bytes and a few > clocks of a path that actually gets executed.
This is about kernel image size as well. This version of the patch bloats the kernel. The death of a thousand cuts ...
> Arnd - can you send me a diff that keeps the existing horrible > macro version, the existing __put_user usage and just fixes c_line > ? It's worked for 15 years, its not worth the time being fancy > with it.
Agreed.
Ingo
| |