lkml.org 
[lkml]   [2009]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] x86: fix ktermios-termio conversion

* Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:

> > hm, on x86 you could use get_user_try / get_user_ex() /
> > get_user_catch() approach to linearize the dependencies and
> > reduce register pressure.
>
> It used *once*, in a path that is never executed except by some
> ancient binaries. It isn't worth the effort.

i know, and i tested the patch so i know what effects it has.

I never made any argument about inlining, it's obviously correct to
have a use-once function inline.

My argument was very simple: the patch causes +150 bytes of bloat.
The try/ex/catch method can help reduce register pressure and can
reducethe size of code quite visibly.

Ingo


\
 
 \ /
  Last update: 2009-05-12 11:29    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site