lkml.org 
[lkml]   [2009]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 3/4] reiserfs: fixup perms when xattrs are disabled
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Al Viro wrote:
> On Sun, May 10, 2009 at 04:05:38PM -0400, Jeff Mahoney wrote:
>
>> +#ifdef CONFIG_REISERFS_FS_XATTR
>> + /*
>> + * Stat data v1 doesn't support ACLs.
>> + */
>> + if (get_inode_sd_version(inode) != STAT_DATA_V1)
>> + return generic_permission(inode, mask, reiserfs_check_acl);
>> + else
>> +#endif
>> + return generic_permission(inode, mask, NULL);
>
> Matter of style: this kind of mixing the nesting structures is Not Nice(tm),
> so I'd rather turn that into
>
> +#ifdef CONFIG_REISERFS_FS_XATTR
> + /*
> + * Stat data v1 doesn't support ACLs.
> + */
> + if (get_inode_sd_version(inode) != STAT_DATA_V1)
> + return generic_permission(inode, mask, reiserfs_check_acl);
> +#endif
> +
> + return generic_permission(inode, mask, NULL);

Works for me.

- -Jeff

- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org
iEYEARECAAYFAkoHYw4ACgkQLPWxlyuTD7JdrACfdMo7wPBtIGBadVEBKiviD4i9
H4oAoKf1GtugtaiTVZdwwveaTPxBRD/T
=JiZ1
-----END PGP SIGNATURE-----

\
 
 \ /
  Last update: 2009-05-11 01:31    [from the cache]
©2003-2011 Jasper Spaans