Messages in this thread |  | | | Date | Sun, 10 May 2009 22:35:18 +0100 | | From | Al Viro <> | | Subject | Re: [patch 3/4] reiserfs: fixup perms when xattrs are disabled |
| |
On Sun, May 10, 2009 at 04:05:38PM -0400, Jeff Mahoney wrote:
> +#ifdef CONFIG_REISERFS_FS_XATTR > + /* > + * Stat data v1 doesn't support ACLs. > + */ > + if (get_inode_sd_version(inode) != STAT_DATA_V1) > + return generic_permission(inode, mask, reiserfs_check_acl); > + else > +#endif > + return generic_permission(inode, mask, NULL);
Matter of style: this kind of mixing the nesting structures is Not Nice(tm), so I'd rather turn that into
+#ifdef CONFIG_REISERFS_FS_XATTR + /* + * Stat data v1 doesn't support ACLs. + */ + if (get_inode_sd_version(inode) != STAT_DATA_V1) + return generic_permission(inode, mask, reiserfs_check_acl); +#endif + + return generic_permission(inode, mask, NULL);
|  |